Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update VSTeamJobRequest.ps1 #229

Merged
merged 2 commits into from
Jan 18, 2020
Merged

Conversation

asifma
Copy link
Contributor

@asifma asifma commented Jan 16, 2020

PR Summary

Hi, I made a pull request a while ago #226 . I noticed similar errors for jobs that are "Queued".

Items that are "Queued" does not have properties: assignTime, receiveTime and result
I also added a statement to decide if job is currently "Queued", "running" or $obj.result if property exist.

Without this fix you don't get jobs that are currently "Queued" (you can try it yourself).
Jobs can be queued when all Agents in a pool are busy e.g.
It's critical for me to know how many jobs are currently "Queued" for my Agent Auto-scaling automation.

Hope this fix will be merged soon :)

Best,
Asif Mithawala.

PR Checklist

Hi, I made a pull request a while ago. I noticed similar errors for jobs that are "Queued".

Items that are "Queued" does not have properties: assignTime, receiveTime and result
I also added a statement to decide if job is currently "Queued", "running" or $obj.result if property exist.

Without this fix you don't get jobs that are currently "Queued" (you can try it yourself). 
Jobs can be queued when all Agents in a pool are busy e.g.
It's critical for me to know how many jobs are currently "Queued" for my Agent Auto-scaling automation.

Hope this fix will be merged soon :)

Best,
Asif Mithawala.
Copy link
Collaborator

@SebastianSchuetze SebastianSchuetze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked this and look good to me @DarqueWarrior

@DarqueWarrior
Copy link
Collaborator

Thanks for the continued support @asifma and thanks for the review @SebastianSchuetze

@DarqueWarrior DarqueWarrior merged commit 0c6665d into MethodsAndPractices:master Jan 18, 2020
@DarqueWarrior
Copy link
Collaborator

This version is now the latest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants