-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Task Groups #212
Conversation
Will fix unit tests and re-submit. |
@quintessential5 you don't have to close the pull request. Just work on that branch and commit again until all the code is as it should be. A PR does not have to include 100% working code. You can also open it as a draft. |
@SebastianSchuetze thanks for taking the time to communicate that. I was planning on re-opening the PR as soon as I committed fixes to the breaking unit tests. (I was also embarrassed to have even made a commit with broken tests; I thought I had verified that the tests were successful.) |
Testing to see if re-opening the PR allows the latest commit to automatically show up and for the automated validation to be re-run... |
Reverting a couple commits, in order to put them into a different PR, since I'm trying to make this the "task group support" PR. |
Can you make sure I have permissions to commit to this repo. There are changes I have to push before I this can be merged. |
@DarqueWarrior confirmed: "Allow edits from maintainers" is checked. |
Not sure what is going on. Will keep looking.
|
I wonder if it's due to the fact that it's a UCSB repo; I wonder if there are some parent organizational settings that aren't allowing it to work. On the other hand, it seems we had the same problem with the last pull request of mine, even when I used my personal repo? |
I am going to merge to a local branch and push from there to my repo. I don't want to loose time trying to figure this out. |
I was able to add you as a collaborator to the repo, so maybe it'll work now (it was done around 9:15 or 9:30 Pacific). However, of course, whatever's easiest for you. |
Changes merged into PR #217 |
PR Summary
a minor tweak to my last accepted PR: I didn't _applyTypesToVarGroup on the object returnedPR Checklist