Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Task Groups #212

Closed
wants to merge 7 commits into from

Conversation

quintessential5
Copy link
Contributor

@quintessential5 quintessential5 commented Oct 21, 2019

PR Summary

  • support for task groups
  • a typo fix
  • a minor tweak to my last accepted PR: I didn't _applyTypesToVarGroup on the object returned
  • There are other changes that you made in my last task group PR that you'll want to apply here. I don't know how to get at them.

PR Checklist

@quintessential5
Copy link
Contributor Author

Will fix unit tests and re-submit.

@SebastianSchuetze
Copy link
Collaborator

@quintessential5 you don't have to close the pull request. Just work on that branch and commit again until all the code is as it should be. A PR does not have to include 100% working code. You can also open it as a draft.

@quintessential5
Copy link
Contributor Author

@quintessential5 you don't have to close the pull request. Just work on that branch and commit again until all the code is as it should be. A PR does not have to include 100% working code. You can also open it as a draft.

@SebastianSchuetze thanks for taking the time to communicate that. I was planning on re-opening the PR as soon as I committed fixes to the breaking unit tests. (I was also embarrassed to have even made a commit with broken tests; I thought I had verified that the tests were successful.)

@quintessential5
Copy link
Contributor Author

Testing to see if re-opening the PR allows the latest commit to automatically show up and for the automated validation to be re-run...

@quintessential5
Copy link
Contributor Author

Reverting a couple commits, in order to put them into a different PR, since I'm trying to make this the "task group support" PR.

@DarqueWarrior
Copy link
Collaborator

Can you make sure I have permissions to commit to this repo. There are changes I have to push before I this can be merged.

@quintessential5
Copy link
Contributor Author

Can you make sure I have permissions to commit to this repo. There are changes I have to push before I this can be merged.

@DarqueWarrior confirmed: "Allow edits from maintainers" is checked.

@DarqueWarrior
Copy link
Collaborator

Can you make sure I have permissions to commit to this repo. There are changes I have to push before I this can be merged.

@DarqueWarrior confirmed: "Allow edits from maintainers" is checked.

Not sure what is going on. Will keep looking.

remote: Permission to ucsb/ucsb-sa-enterprise-vsteam.git denied to DarqueWarrior.
fatal: unable to access 'https://github.com/ucsb/ucsb-sa-enterprise-vsteam.git/': The requested URL returned error: 403

@quintessential5
Copy link
Contributor Author

quintessential5 commented Nov 7, 2019

remote: Permission to ucsb/ucsb-sa-enterprise-vsteam.git denied to DarqueWarrior.
fatal: unable to access 'https://github.com/ucsb/ucsb-sa-enterprise-vsteam.git/': The requested URL returned error: 403

I wonder if it's due to the fact that it's a UCSB repo; I wonder if there are some parent organizational settings that aren't allowing it to work.

On the other hand, it seems we had the same problem with the last pull request of mine, even when I used my personal repo?

@DarqueWarrior
Copy link
Collaborator

I am going to merge to a local branch and push from there to my repo. I don't want to loose time trying to figure this out.

@quintessential5
Copy link
Contributor Author

I am going to merge to a local branch and push from there to my repo. I don't want to loose time trying to figure this out.

I was able to add you as a collaborator to the repo, so maybe it'll work now (it was done around 9:15 or 9:30 Pacific). However, of course, whatever's easiest for you.

@DarqueWarrior DarqueWarrior mentioned this pull request Nov 7, 2019
4 tasks
@DarqueWarrior
Copy link
Collaborator

Changes merged into PR #217

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants