Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add membership functions #178

Merged

Conversation

Seekatar
Copy link
Contributor

PR Summary

Added functions to add/delete/get Memberships. I didn't add a type or format in this PR since memberships are just two ids. I'd like to do another PR to add a Permissions container to the PSDrive with Group and User child items.

PR Checklist

@Seekatar
Copy link
Contributor Author

I see the build failed in the UT, but I can't reproduce locally on PS 5,6, or 7. All succeed for me.

@DarqueWarrior
Copy link
Collaborator

reviewing now. Sometimes it fails due to the lack of permissions of PR builds.

@DarqueWarrior
Copy link
Collaborator

Can you clear this warning?
##[warning]dist\vsteam.functions.ps1(5507,10): Warning : Function 'Remove-VSTeamMembership' has verb that could change system state. Therefore, the function has to support 'ShouldProcess'.

@Seekatar Seekatar force-pushed the add-membership-functions branch from 7ca95fe to e192937 Compare July 29, 2019 11:14
@Seekatar
Copy link
Contributor Author

Warning fixed.
Btw, I work with Jeffery at Clear-Measure and I've been using VSTeam for automating AzDo for a while. I added some extensions, and am finally getting around to making some PRs. Great lib!

@Seekatar
Copy link
Contributor Author

Seekatar commented Aug 1, 2019

I think the UT error is the cached call to project. I added code I saw from other tests to avoid calling it.

@DarqueWarrior
Copy link
Collaborator

Sorry for delay. I will try to get to this this week.

@DarqueWarrior DarqueWarrior merged commit fbc3a09 into MethodsAndPractices:master Aug 6, 2019
@Seekatar Seekatar deleted the add-membership-functions branch August 7, 2019 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants