Issue159 (#161)

* Fixing issue 159. Changed ExtendedInfo from hashtable to PSCustomObject. * Added integration tests for Access control * Updated version and change log
MethodsAndPractices · May 16, 2019 · d60854b · d60854b
1 parent bae1f60
commit d60854b
Show file tree

Hide file tree

Showing 7 changed files with 28 additions and 5 deletions.
diff --git a/.docs/Get-VSTeamAccessControlList.md b/.docs/Get-VSTeamAccessControlList.md
@@ -14,6 +14,12 @@
 
 ## EXAMPLES
 
+### -------------------------- EXAMPLE 1 --------------------------
+
+```PowerShell
+Get-VSTeamSecurityNamespace | Select-Object -First 1 | Get-VSTeamAccessControlList
+```
+
 ## PARAMETERS
 
 ### -SecurityNamespace

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Changelog
 
+## 6.2.3
+
+Fixes issue [Get-VSTeamAccessControlList -IncludeExtendedInfo. Cannot convert value PSCustomObject to type Hashtable #159](https://github.com/DarqueWarrior/vsteam/issues/159)
+
 ## 6.2.2
 
 Merged [Pull Request](https://github.com/DarqueWarrior/vsteam/pull/158) from [Ryan](https://github.com/RPhay) which included the following:

diff --git a/Source/Classes/VSTeamAccessControlEntry.ps1 b/Source/Classes/VSTeamAccessControlEntry.ps1
@@ -6,7 +6,7 @@ class VSTeamAccessControlEntry : VSTeamLeaf {
    [string]$Descriptor = $null
    [int]$Allow = 0
    [int]$Deny = 0
-   [hashtable]$ExtendedInfo = @{}
+   [PSCustomObject]$ExtendedInfo = @{}
 
    VSTeamAccessControlEntry (
       [object]$obj

diff --git a/Source/Public/Get-VSTeamAccessControlList.ps1 b/Source/Public/Get-VSTeamAccessControlList.ps1
@@ -4,7 +4,8 @@ function Get-VSTeamAccessControlList {
       [Parameter(ParameterSetName = 'ByNamespace', Mandatory = $true, ValueFromPipeline = $true)]
       [VSTeamSecurityNamespace] $SecurityNamespace,
 
-      [Parameter(ParameterSetName = 'ByNamespaceId', Mandatory = $true)]
+      [Parameter(ParameterSetName = 'ByNamespaceId', Mandatory = $true, ValueFromPipeline = $true, ValueFromPipelineByPropertyName = $true)]
+      [Alias('ID')]
       [ValidateScript({
          try {
              [System.Guid]::Parse($_) | Out-Null

diff --git a/Source/VSTeam.psd1 b/Source/VSTeam.psd1
@@ -12,7 +12,7 @@
    RootModule        = 'VSTeam.psm1'
 
    # Version number of this module.
-   ModuleVersion     = '6.2.2'
+   ModuleVersion     = '6.2.3'
 
    # Supported PSEditions
    # CompatiblePSEditions = @()

diff --git a/integration/test/010_projects.Tests.ps1 b/integration/test/010_projects.Tests.ps1
@@ -408,6 +408,18 @@ InModuleScope VSTeam {
          }
       }
 
+      # Not supported on TFS
+      if (-not ($acct -like "http://*")) {
+         Context 'Access control list' {
+            It 'Get-VSTeamAccessControlList should return without error' {
+               $(Get-VSTeamSecurityNamespace | Select-Object -First 1 | Get-VSTeamAccessControlList) | Should Not Be $null
+            }
+
+            It 'Get-VSTeamAccessControlList -IncludeExtendedInfo should return without error' {
+               $(Get-VSTeamSecurityNamespace | Select-Object -First 1 | Get-VSTeamAccessControlList -IncludeExtendedInfo) | Should Not Be $null
+            }
+         }
+      }
 
       Context 'Teams full exercise' {
          It 'Get-VSTeam ByName Should return Teams' {

diff --git a/unit/test/accessControlList.Tests.ps1 b/unit/test/accessControlList.Tests.ps1
@@ -7,7 +7,7 @@ InModuleScope VSTeam {
    [VSTeamVersions]::Account = 'https://dev.azure.com/test'
 
    $accessControlListResult =
-@"
+   @"
 {
    "count": 5,
    "value": [
@@ -96,7 +96,7 @@ InModuleScope VSTeam {
 "@ | ConvertFrom-Json
 
    $securityNamespace = 
-@"
+   @"
 {
    "count": 1,
    "value": [