Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaces underscore references with native one #161

Conversation

Nandika-A
Copy link
Contributor

Resolves #158

Underscore references in certain files where possible are replaced with native ones as referenced in https://github.com/you-dont-need/You-Dont-Need-Lodash-Underscore. Currently, the native version isn't available for _.any() and _.isEqual() in lines 69 and 70 in lib/subscription.js, so these are skipped for now. The following changes are made-

  1. _.each(list, function) to Object.entries(object).forEach(function)
    Nandika-A@da63cfa
  2. _.extend(destination, *sources) to Object.assign(destination, *sources)
    Nandika-A@6d5f2a0
    Nandika-A@da3aff7
  3. _.keys(object) to Object.keys(object)
    Nandika-A@6d5f2a0

The changes are made in a separate branch Replaces underscore references with native one.
The remaining underscore functions will be tackled in other pr.

Copy link
Member

@StorytellerCZ StorytellerCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great first step. Still more underscore remains, but as I described in the issue that can be taken care of in another PR.

@StorytellerCZ StorytellerCZ merged commit d073b79 into Meteor-Community-Packages:master Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove underscore
2 participants