fix: Reload client side tests 2 #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @StorytellerCZ what do you think? |
|
@jirikrepl just some questions for testing it - do you run your tests in the browser or do you do headless testing with puppeteer or similar? Just want to focus on the modes you don't use. Regarding 5% - what means "crash" ? Freezing? Or just doing nothing? Error messages? |
|
I am running client tests in headless mode with puppeteer. That 5% cases print some error about browser crash, but I am not sure. I would post it here when I see it again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR fix the lint errors of this PR #106
After my use (8+ months) as a local package with this PR #106 I think it is good to merge as-is.
Client-side tests are reloaded correctly with this PR 95% time. Without this PR client-side tests are not reloaded at all.
Rarely (5%) Chrome would crash when watching client tests, and mocha would need to be restarted.