Remove the need of reflection of p2p message (de)serialization #1195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… string instead of the using the reflection `Activator` class based on the type decorated info.
A `Message` comes always with a Payload type and never with any other type. This means that a `Message` can come with a `BlockPayload` type but never with a `Block` type. So, the `ConsensusFactory` is unnecessary.
|
Ping @NicolasDorier |
|
I reordered the messages based on my experience but I have no numbers to tell me which messages are more frequent. |
NicolasDorier
force-pushed
the
reflection
branch
from
8ff2672 to
a82fd30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reflection makes code stripping impossible and that's an impediment for fully supporting AOT.
This PR is a first step in the removal of reflection and here we start from removing it from the peer-to-peer message serialization/deserialization.
Note: sorry for the eol change in NBitcoin/Protocol/Payloads/AddrPayload.cs, the truth is that NBitcoin has a problem of inconsistency where half of the files are CRLF while the other half are LF so, it is always painful for any contributor.