Fix: FeeRate.GetFee would return 1000x more fee if the fee for the vi…

…rtualSize was less than 1 sat
MetacoSA · Sep 23, 2022 · fe7a177 · fe7a177
1 parent 738be49
commit fe7a177
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/NBitcoin.Tests/util_tests.cs b/NBitcoin.Tests/util_tests.cs
@@ -677,6 +677,15 @@ public void Overflow()
 			Assert.Throws<OverflowException>(() => -1 * (Money)long.MinValue);
 		}
 
+
+		[Fact]
+		[Trait("UnitTest", "UnitTest")]
+		public void FeeRateCalculation()
+		{
+			Assert.Equal(Money.Satoshis(1L), new FeeRate(0.5m).GetFee(1));
+			Assert.Equal(Money.Satoshis(3L), new FeeRate(3m).GetFee(1));
+		}
+
 		[Fact]
 		[Trait("UnitTest", "UnitTest")]
 		public void FeeRateFormatting()

diff --git a/NBitcoin/FeeRate.cs b/NBitcoin/FeeRate.cs
@@ -76,8 +76,8 @@ public FeeRate(decimal satoshiPerByte)
 		public Money GetFee(int virtualSize)
 		{
 			Money nFee = _FeePerK.Satoshi * virtualSize / 1000;
-			if (nFee == Money.Zero && _FeePerK.Satoshi > Money.Zero)
-				nFee = _FeePerK.Satoshi;
+			if (nFee == Money.Zero)
+				nFee = Money.Satoshis(1.0m);
 			return nFee;
 		}
 		public Money GetFee(Transaction tx)