Issue #286: dont't fail tests because of github rate limiting errors

Metacello · Oct 18, 2014 · 263fe52 · 263fe52
1 parent a2508fa
commit 263fe52
Show file tree

Hide file tree

Showing 10 changed files with 32 additions and 14 deletions.
diff --git a/...ge/MetacelloGithubIssue277TestCase.class/instance/testGithubRepositoryPatternMatchingA.st b/...ge/MetacelloGithubIssue277TestCase.class/instance/testGithubRepositoryPatternMatchingA.st
@@ -14,4 +14,7 @@ testGithubRepositoryPatternMatchingA
       Transcript
         cr;
         show: 'testGithubRepositoryPatternMatchingA: ' , ex description.
-      ex pass ]
+      (ex description includesSubstring: 'API rate limit exceeded')
+        ifFalse: [ 
+          "don't fail test because github rate limit exceeded"
+          ex pass ] ]
diff --git a/...ge/MetacelloGithubIssue277TestCase.class/instance/testGithubRepositoryPatternMatchingE.st b/...ge/MetacelloGithubIssue277TestCase.class/instance/testGithubRepositoryPatternMatchingE.st
@@ -12,4 +12,7 @@ testGithubRepositoryPatternMatchingE
       Transcript
         cr;
         show: 'testGithubRepositoryPatternMatchingE: ' , ex description.
-      ex pass ]
+      (ex description includesSubstring: 'API rate limit exceeded')
+        ifFalse: [ 
+          "don't fail test because github rate limit exceeded"
+          ex pass ] ]
diff --git a/...ry/Metacello-TestsMCA.package/MetacelloGithubIssue277TestCase.class/methodProperties.json b/...ry/Metacello-TestsMCA.package/MetacelloGithubIssue277TestCase.class/methodProperties.json
@@ -10,11 +10,11 @@
 		"testBitbucketRepositoryPatternMatchingC" : "dkh 10/14/2014 15:23",
 		"testBitbucketRepositoryPatternMatchingD" : "dkh 10/15/2014 14:39",
 		"testGitHubJSONParse" : "dkh 10/14/2014 15:24",
-		"testGithubRepositoryPatternMatchingA" : "dkh 10/15/2014 17:12",
+		"testGithubRepositoryPatternMatchingA" : "dkh 10/18/2014 08:21",
 		"testGithubRepositoryPatternMatchingB" : "dkh 10/14/2014 15:23",
 		"testGithubRepositoryPatternMatchingC" : "dkh 10/14/2014 15:23",
 		"testGithubRepositoryPatternMatchingD" : "dkh 10/15/2014 14:39",
-		"testGithubRepositoryPatternMatchingE" : "dkh 10/15/2014 17:12",
+		"testGithubRepositoryPatternMatchingE" : "dkh 10/18/2014 08:21",
 		"testUrlParsingA" : "dkh 10/13/2014 13:17",
 		"testUrlParsingB" : "dkh 10/13/2014 15:28",
 		"testUrlParsingIssue234" : "dkh 10/13/2014 13:13",

diff --git a/repository/Metacello-TestsMCA.package/monticello.meta/version b/repository/Metacello-TestsMCA.package/monticello.meta/version
diff --git a/...MCB.package/MetacelloScriptingSuccessTestCase.class/instance/testGitHubTagPatternLoad1.st b/...MCB.package/MetacelloScriptingSuccessTestCase.class/instance/testGitHubTagPatternLoad1.st
@@ -28,4 +28,7 @@ bea35be90ab1ba0be80af4f4275fccbfc071a74f - v2.2.0-gs
       Transcript
         cr;
         show: 'testGitHubTagPatternLoad1: ' , ex description.
-      ex pass ]
+      (ex description includesSubstring: 'API rate limit exceeded')
+        ifFalse: [ 
+          "don't fail test because github rate limit exceeded"
+          ex pass ] ]
diff --git a/...MCB.package/MetacelloScriptingSuccessTestCase.class/instance/testGitHubTagPatternLoad2.st b/...MCB.package/MetacelloScriptingSuccessTestCase.class/instance/testGitHubTagPatternLoad2.st
@@ -28,4 +28,7 @@ bea35be90ab1ba0be80af4f4275fccbfc071a74f - v2.2.0-gs
       Transcript
         cr;
         show: 'testGitHubTagPatternLoad2: ' , ex description.
-      ex pass ]
+      (ex description includesSubstring: 'API rate limit exceeded')
+        ifFalse: [ 
+          "don't fail test because github rate limit exceeded"
+          ex pass ] ]
diff --git a/...CB.package/MetacelloScriptingSuccessTestCase.class/instance/testGitHubTagPatternLoad2B.st b/...CB.package/MetacelloScriptingSuccessTestCase.class/instance/testGitHubTagPatternLoad2B.st
@@ -28,4 +28,7 @@ bea35be90ab1ba0be80af4f4275fccbfc071a74f - v2.2.0-gs
       Transcript
         cr;
         show: 'testGitHubTagPatternLoad2B: ' , ex description.
-      ex pass ]
+      (ex description includesSubstring: 'API rate limit exceeded')
+        ifFalse: [ 
+          "don't fail test because github rate limit exceeded"
+          ex pass ] ]
diff --git a/...MCB.package/MetacelloScriptingSuccessTestCase.class/instance/testGitHubTagPatternLoad3.st b/...MCB.package/MetacelloScriptingSuccessTestCase.class/instance/testGitHubTagPatternLoad3.st
@@ -28,4 +28,7 @@ bea35be90ab1ba0be80af4f4275fccbfc071a74f - v2.2.0-gs
       Transcript
         cr;
         show: 'testGitHubTagPatternLoad3: ' , ex description.
-      ex pass ]
+      (ex description includesSubstring: 'API rate limit exceeded')
+        ifFalse: [ 
+          "don't fail test because github rate limit exceeded"
+          ex pass ] ]
diff --git a/.../Metacello-TestsMCB.package/MetacelloScriptingSuccessTestCase.class/methodProperties.json b/.../Metacello-TestsMCB.package/MetacelloScriptingSuccessTestCase.class/methodProperties.json
@@ -22,10 +22,10 @@
 		"testFileTreeLoadMarianosImage1" : "dkh 6/22/2012 17:53",
 		"testFileTreeLoadMarianosImage2" : "dkh 6/22/2012 17:54",
 		"testGitHubLoad1" : "dkh 6/15/2012 05:18",
-		"testGitHubTagPatternLoad1" : "dkh 10/16/2014 22:12",
-		"testGitHubTagPatternLoad2" : "dkh 10/15/2014 17:10",
-		"testGitHubTagPatternLoad2B" : "dkh 10/15/2014 17:10",
-		"testGitHubTagPatternLoad3" : "dkh 10/15/2014 17:10",
+		"testGitHubTagPatternLoad1" : "dkh 10/18/2014 08:21",
+		"testGitHubTagPatternLoad2" : "dkh 10/18/2014 08:22",
+		"testGitHubTagPatternLoad2B" : "dkh 10/18/2014 08:22",
+		"testGitHubTagPatternLoad3" : "dkh 10/18/2014 08:22",
 		"testGithubRefBaselineLoad1" : "dkh 6/15/2012 05:20",
 		"testGithubRefBaselineLoad2" : "dkh 6/15/2012 05:21",
 		"testGithubRefBaselineLoad3" : "dkh 6/15/2012 05:22",

diff --git a/repository/Metacello-TestsMCB.package/monticello.meta/version b/repository/Metacello-TestsMCB.package/monticello.meta/version