-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: update models #32
Conversation
Nice! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! It would be nice to get another Mac users input (ping @e0 or @mihai-sysbio) to see if they have the problem with weird text when searching. If so I don't think we should merge this before it is fixed.
And regarding the mismatch of Yeast-GEM version, I think it makes sense to create a new issue for this
I can confirm that this problem shows up in Safari here too. Will try to go through the PR now to see if I can spot anything. |
I looked up this Safari problem a bit now. It seems like a It seems like it's only affecting |
It seems like most of these were done in this PR. It was merged at the end of May though so I'm a bit confused why the production site doesn't have these versions since we have deployed to it after that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @nanjiangshu!
As @e0 pointed out, most of the models are updated in #29 already in May. I guess the reason why old models are still used on the production server https://metabolicatlas.org/ is that the repo |
Many thanks to @e0 to figure out the problem with weird characters and good to know that it affects (hopefully) only the development mode. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@inghylt Do you have any other comments to this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
This PR together with MetabolicAtlas/MetabolicAtlas#1145 closes #1081
Changes been done
For Yeast-GEM
subsystemSVG.tsv
and the YAML file are fixed manuallycustomSVG.tsv
Regarding the mismatch of Yeast-GEM version cased by the patch releases, that is, v8.6.2 is shown in the integrated models panel but v8.6.0 is shown in the history map, it is probably good to add an explanation somewhere. Since there is no such text at any place regarding the history map, I think it is better to address this problem in a new issue.
Details can be found in this comment
Additional info
I've found a problem some weird text shown in the model search result table when viewing on Safari, but not on Firefox nor Chrome. Please verify if it is the case for you as well. For me, the problem exist when building with all
main
branches.