Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix addEthereumChain button disable logic #93

Merged
merged 2 commits into from
Mar 10, 2021
Merged

Fix addEthereumChain button disable logic #93

merged 2 commits into from
Mar 10, 2021

Conversation

rekmarks
Copy link
Member

The button should be disabled if MetaMask is not installed, just like every other button.

@rekmarks rekmarks requested a review from a team as a code owner March 10, 2021 20:09
Gudahtt
Gudahtt previously approved these changes Mar 10, 2021
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rekmarks rekmarks merged commit 38354a8 into master Mar 10, 2021
@rekmarks rekmarks deleted the fix-addEthereumChain-disable-logic branch March 10, 2021 20:12
@brad-decker brad-decker mentioned this pull request Feb 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rekmarks @Gudahtt