fix: Fix network status field #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The network status field would show the `networkId` on load (in decimal), but after switching chains it would show the `chainId` (in hex). It now shows the `networkId` in all cases. This means re-introducing the deprecated `networkChanged` event listener, but this listener is still something we want to be able to test.
Gudahtt
force-pushed
the
fix-network-format
branch
from
46d2a6b
to
8ceea0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The network status field would show the
networkIdon load (in decimal), but after switching chains it would show thechainId(in hex). It now shows thenetworkIdin all cases.This means re-introducing the deprecated
networkChangedevent listener, but this listener is still something we want to be able to test.