Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch eth-sig-util to @metamask/eth-sig-util #286

Merged
merged 9 commits into from
Apr 30, 2024
Merged

Conversation

tmashuang
Copy link
Contributor

Switch over the user of eth-sig-util to @metamask/eth-sig-util and update method params.

Copy link

socket-security bot commented Jan 24, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/[email protected]

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@legobeat legobeat requested review from Gudahtt, seaona and rekmarks and removed request for Gudahtt and seaona April 15, 2024 06:21
package.json Outdated Show resolved Hide resolved
@legobeat
Copy link
Contributor

@SocketSecurity ignore npm/[email protected]

network access ok

Copy link
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tmashuang tmashuang merged commit 314b221 into main Apr 30, 2024
7 checks passed
@tmashuang tmashuang deleted the mm-eth-sig-util branch April 30, 2024 23:55
@seaona seaona mentioned this pull request May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants