Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add: support malicious tx's in multiple networks #281

Merged
merged 3 commits into from
Nov 30, 2023
Merged

add: support malicious tx's in multiple networks #281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6554779
Support malicious tx's in multiple networks
seaona Nov 30, 2023
c0ebcf0
handle mainnet and non-supported chains
seaona Nov 30, 2023
93718ba
remove suggested gas
seaona Nov 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 34 additions & 8 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,11 @@ import { ethers } from 'ethers';
import { toChecksumAddress } from 'ethereumjs-util';
import { getPermissionsDisplayString, stringifiableToHex } from './utils';
import Constants from './constants.json';
import {
NETWORKS_BY_CHAIN_ID,
ERC20_SAMPLE_CONTRACTS,
ERC721_SAMPLE_CONTRACTS,
} from './onchain-sample-contracts';

const {
hstBytecode,
Expand Down Expand Up @@ -489,11 +494,13 @@ const handleNewAccounts = (newAccounts) => {
};

let chainIdInt;
let networkName;

const handleNewChain = (chainId) => {
chainIdDiv.innerHTML = chainId;
const networkId = parseInt(networkDiv.innerHTML, 10);
chainIdInt = parseInt(chainIdDiv.innerHTML, 16) || networkId;
networkName = NETWORKS_BY_CHAIN_ID[chainIdInt];

if (chainId === '0x1') {
warningDiv.classList.remove('warning-invisible');
Expand Down Expand Up @@ -1302,15 +1309,20 @@ const initializeFormElements = () => {

// Malicious ERC20 Approval
maliciousApprovalButton.onclick = async () => {
let erc20Contract;

if (networkName) {
erc20Contract = ERC20_SAMPLE_CONTRACTS[networkName];
} else {
erc20Contract = '0x4fabb145d64652a948d72533023f6e7a623c7c53';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we handle the rest of not supported networks, defaulting to this address, which is the malicious address we had for main

}
const result = await ethereum.request({
method: 'eth_sendTransaction',
params: [
{
from: accounts[0],
to: '0x4fabb145d64652a948d72533023f6e7a623c7c53',
gas: '0x30d40',
to: erc20Contract,
data: '0x095ea7b3000000000000000000000000e50a2dbc466d01a34c3e8b7e8e45fce4f7da39e6000000000000000000000000000000000000000000000000ffffffffffffffff',
gasPrice: '0x76c3b0342',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we remove suggested gas to avoid gas issues, so gas is calculated based on the network we are - we don't need to change this for each network

},
],
});
Expand All @@ -1319,15 +1331,21 @@ const initializeFormElements = () => {

// Malicious ERC20 transfer
maliciousERC20TransferButton.onclick = async () => {
let erc20Contract;

if (networkName) {
erc20Contract = ERC20_SAMPLE_CONTRACTS[networkName];
} else {
erc20Contract = '0xA0b86991c6218b36c1d19D4a2e9Eb0cE3606eB48';
}

const result = await ethereum.request({
method: 'eth_sendTransaction',
params: [
{
from: accounts[0],
to: '0xA0b86991c6218b36c1d19D4a2e9Eb0cE3606eB48',
gas: '0x30d40',
to: erc20Contract,
data: '0xa9059cbb0000000000000000000000005fbdb2315678afecb367f032d93f642f64180aa30000000000000000000000000000000000000000000000000000000000000064',
gasPrice: '0x76c3b0342',
},
],
});
Expand Down Expand Up @@ -1367,7 +1385,7 @@ const initializeFormElements = () => {
method: 'eth_signTypedData_v4',
params: [
accounts[0],
`{"types":{"ERC721Order":[{"type":"uint8","name":"direction"},{"type":"address","name":"maker"},{"type":"address","name":"taker"},{"type":"uint256","name":"expiry"},{"type":"uint256","name":"nonce"},{"type":"address","name":"erc20Token"},{"type":"uint256","name":"erc20TokenAmount"},{"type":"Fee[]","name":"fees"},{"type":"address","name":"erc721Token"},{"type":"uint256","name":"erc721TokenId"},{"type":"Property[]","name":"erc721TokenProperties"}],"Fee":[{"type":"address","name":"recipient"},{"type":"uint256","name":"amount"},{"type":"bytes","name":"feeData"}],"Property":[{"type":"address","name":"propertyValidator"},{"type":"bytes","name":"propertyData"}],"EIP712Domain":[{"name":"name","type":"string"},{"name":"version","type":"string"},{"name":"chainId","type":"uint256"},{"name":"verifyingContract","type":"address"}]},"domain":{"name":"ZeroEx","version":"1.0.0","chainId":${chainIdInt},"verifyingContract":"0xdef1c0ded9bec7f1a1670819833240f027b25eff"},"primaryType":"ERC721Order","message":{"direction":"0","maker":"${accounts[0]}","taker":"0x0000000000000000000000000000000000000000","expiry":"2524604400","nonce":"100131415900000000000000000000000000000083840314483690155566137712510085002484","erc20Token":"0xc02aaa39b223fe8d0a0e5c4f27ead9083c756cc2","erc20TokenAmount":"42000000000000","fees":[],"erc721Token":"0x8a90CAb2b38dba80c64b7734e58Ee1dB38B8992e","erc721TokenId":"2516","erc721TokenProperties":[]}}`,
`{"types":{"ERC721Order":[{"type":"uint8","name":"direction"},{"type":"address","name":"maker"},{"type":"address","name":"taker"},{"type":"uint256","name":"expiry"},{"type":"uint256","name":"nonce"},{"type":"address","name":"erc20Token"},{"type":"uint256","name":"erc20TokenAmount"},{"type":"Fee[]","name":"fees"},{"type":"address","name":"erc721Token"},{"type":"uint256","name":"erc721TokenId"},{"type":"Property[]","name":"erc721TokenProperties"}],"Fee":[{"type":"address","name":"recipient"},{"type":"uint256","name":"amount"},{"type":"bytes","name":"feeData"}],"Property":[{"type":"address","name":"propertyValidator"},{"type":"bytes","name":"propertyData"}],"EIP712Domain":[{"name":"name","type":"string"},{"name":"version","type":"string"},{"name":"chainId","type":"uint256"},{"name":"verifyingContract","type":"address"}]},"domain":{"name":"ZeroEx","version":"1.0.0","chainId":${chainIdInt},"verifyingContract":"0xdef1c0ded9bec7f1a1670819833240f027b25eff"},"primaryType":"ERC721Order","message":{"direction":"0","maker":"${accounts[0]}","taker":"0x5FbDB2315678afecb367f032d93F642f64180aa3","expiry":"2524604400","nonce":"100131415900000000000000000000000000000083840314483690155566137712510085002484","erc20Token":"0xc02aaa39b223fe8d0a0e5c4f27ead9083c756cc2","erc20TokenAmount":"42000000000000","fees":[],"erc721Token":"0x8a90CAb2b38dba80c64b7734e58Ee1dB38B8992e","erc721TokenId":"2516","erc721TokenProperties":[]}}`,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

malicious trade order signature was not being flag on the new networks Blockaid support, so we change this signature data so, this new signature is flagged in all networks

],
});
console.log(result);
Expand All @@ -1387,12 +1405,20 @@ const initializeFormElements = () => {

// Malicious Set Approval For All
maliciousSetApprovalForAll.onclick = async () => {
let erc721Contract;

if (networkName) {
erc721Contract = ERC721_SAMPLE_CONTRACTS[networkName];
} else {
erc721Contract = '0xbc4ca0eda7647a8ab7c2061c2e118a18a936f13d';
}

const result = await ethereum.request({
method: 'eth_sendTransaction',
params: [
{
from: accounts[0],
to: '0xbc4ca0eda7647a8ab7c2061c2e118a18a936f13d',
to: erc721Contract,
data: '0xa22cb465000000000000000000000000b85492afc686d5ca405e3cd4f50b05d358c75ede0000000000000000000000000000000000000000000000000000000000000001',
},
],
Expand Down
24 changes: 24 additions & 0 deletions src/onchain-sample-contracts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
// Contracts for Malicious Transactions in different chains
export const NETWORKS_BY_CHAIN_ID = {
137: 'polygon',
10: 'optimism',
56: 'bsc',
43114: 'avalanche',
42161: 'arbitrum',
};

export const ERC20_SAMPLE_CONTRACTS = {
polygon: '0x2791bca1f2de4661ed88a30c99a7a9449aa84174',
optimism: '0x0b2C639c533813f4Aa9D7837CAf62653d097Ff85',
bsc: '0x8965349fb649A33a30cbFDa057D8eC2C48AbE2A2',
avalanche: '0xB97EF9Ef8734C71904D8002F8b6Bc66Dd9c48a6E',
arbitrum: '0xaf88d065e77c8cC2239327C5EDb3A432268e5831',
};

export const ERC721_SAMPLE_CONTRACTS = {
polygon: '0x9e8ea82e76262e957d4cc24e04857a34b0d8f062',
optimism: '0xaf18644083151cf57f914cccc23c42a1892c218e',
bsc: '0xebfbfd7c41b123500fb16b71c43b400c12b08be0',
avalanche: '0x880f7e04D722e305126F7E1efd3434A7d5b1465c',
arbitrum: '0x8659a4876369b94515a86048fe7f99daba6b9a7d',
};
Loading