Jl/mmp 869/eip 6963 (tmashuang edit) #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmashuang
changed the title
|
Definitely messed something up, unable to run e2e tests with these changes. |
jiexi
reviewed
Oct 20, 2023
jiexi
reviewed
Oct 20, 2023
|
I probably shouldn't be the one to ultimately review this since i originally made these changes |
This was referenced Oct 20, 2023
Closed
…error message of same name, rdns, and image of existing provider uuid.
tmashuang
force-pushed
the
tmashuang-eip6963-edit
branch
from
8faa2de
to
f79e00b
Compare
|
I am marking this ready for review. Idk what is going on the extension side of the e2e tests, hopefully this update won't break them. My local issues with them consist of not being able to run the entire suite to check for issues against this PR and inconsistent accounts/fixture data/connecting issues. I didnt find any issues manual locally testing with a dev build and this pr. |
brad-decker
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is alternative to #243 where it has been rebased with main since its creation date. Also adds eip6963 provider detection on page load.
eip6963-test-dapp.mov