Warn users when using Test Dapp on Mainnet #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified by QA |
david0xd
previously approved these changes
Nov 5, 2021
rekmarks
requested changes
Nov 8, 2021
src/index.js
Outdated
Comment on lines
1071
to
1076
|
|
||
| if (networkId === '1') { | ||
| warningDiv.classList.remove('warning-invisible'); | ||
| } else { | ||
| warningDiv.classList.add('warning-invisible'); | ||
| } |
There was a problem hiding this comment.
We're trying to avoid using the networkId as much as possible. We should move this logic to handleNewChain and check against the chainId instead, which will always be 0x1 for Mainnet.
src/index.html
Outdated
| class="error-message-icon | ||
| " | ||
| /> | ||
| <div class="error-message-text">You are using Test Dapp on Mainnet</div> |
There was a problem hiding this comment.
Suggested change
| <div class="error-message-text">You are using Test Dapp on Mainnet</div> | |
| <div class="error-message-text">You are on the Ethereum Mainnet.</div> |
ryanml
reviewed
Nov 8, 2021
src/index.css
Outdated
|
|
||
| .warning-invisible { | ||
| display:none; | ||
| } |
There was a problem hiding this comment.
nit: could we add a newline at the end of the file here?
ryanml
reviewed
Nov 8, 2021
src/index.css
Outdated
| } | ||
|
|
||
| .warning-invisible { | ||
| display:none; |
There was a problem hiding this comment.
Suggested change
| display:none; | |
| display: none; |
danjm
approved these changes
Nov 10, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #56
If a user uses Test Dapp on Mainnet, a warning will be shown.
Screencast.2021-11-05.09.34.11.mp4