Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a transaction creation form so that a tx with any parameters can be created #128

Closed
danjm opened this issue Oct 4, 2021 · 4 comments
Assignees

Comments

@danjm
Copy link
Contributor

danjm commented Oct 4, 2021

It would be good if our test dapp had a form, with fields for each tx parameter, that could be filled in with any arbitrary values.

This should include the ability to set the transaction type (only to 0x0 or 0x2 for now). Appropriate gas fields should be shown for the appropriate type.

@danjm danjm added this to the Q4-Improvements milestone Oct 4, 2021
@danjm
Copy link
Contributor Author

danjm commented Oct 22, 2021

Add a new section at the bottom of the test dapp.

The section can be titled "Send form"

This section should contain the following labelled inputs:

  • From
  • To
  • Amount
  • Max Fee (only if type is 2)
  • Max Priority Fee (only if type is 2)
  • Gas Price (only if type is 0)
  • type
  • Data

They should all be string inputs.

The "From" field should be auto-filled with the current account.

There should be a button for submitting the form. Clicking the button should result in creating a transaction. You can follow the code for the send transaction buttons in the test dapp for direction on how to do that.

@bschorchit
Copy link

Should this be closed as #132 was merged?

@dragana8
Copy link
Contributor

dragana8 commented Aug 3, 2022

@bschorchit I think it should.

@mcmire
Copy link
Collaborator

mcmire commented Dec 14, 2022

Closing issue since #132 was merged.

@mcmire mcmire closed this as completed Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants