Ensure transaction parameters from dapps are valid hex

[danjm]

See metamask-extension/app/scripts/controllers/transactions/lib/util.js

[david0xd]

Hi @danjm, can you please provide more information on this?
Are we verifying here the custom user input from the UI or the whole transaction parameter data internally?
I'm considering this function as the target to validate the HEX: validateTxParams(txParams, eip1559Compatibility = true).
I'm interested from where I can trigger the action (test-dapp) so we can later see the bad parameter inputs?
If you can provide a screenshot if this can be validated from the UI, it will also be very useful.

[danjm]

validateTxParams is the correct place to add the validation

An invalid transaction will have to be created from the test dapp. One way to test is you could build the test dapp locally and directly edit the code for sending transactions:

https://github.com/MetaMask/test-dapp/blob/main/src/index.js#L321

It will be easier to test this once this task is resolved MetaMask/test-dapp#128

[vandan]

@hilvmason Can you confirm if any support is needed from the dapp API team to close this issue?
If not, can you remove the "area-api" label? Thank you!

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 45 days if there is no further activity. The MetaMask team intends on reviewing this issue before close, and removing the stale label if it is still a bug. We welcome new comments on this issue. We do not intend on closing issues if they report bugs that are still reproducible. Thank you for your contributions.

[github-actions]

This issue was closed because there has been no follow up activity in the last 45 days. If you feel this was closed in error, please reopen and provide evidence on the latest release of the extension. Thank you for your contributions.