feat: Automatically add platformVersion to manifest
#2938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrederikBolding
commented
Dec 10, 2024
| @@ -21,5 +21,6 @@ | |||
| "dapps": true | |||
| } | |||
| }, | |||
| "platformVersion": "6.13.0", | |||
There was a problem hiding this comment.
This will add a bit of complexity to our release process, but worth it IMO.
Mrtenz
previously approved these changes
Dec 10, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2938 +/- ##
=======================================
Coverage 94.49% 94.49%
=======================================
Files 487 487
Lines 10450 10451 +1
Branches 1604 1604
=======================================
+ Hits 9875 9876 +1
Misses 575 575 ☔ View full report in Codecov by Sentry. |
Mrtenz
reviewed
Dec 10, 2024
| @@ -179,7 +179,7 @@ describe('manifest', () => { | |||
| "chains": ["eip155:1", "eip155:2", "eip155:3"] | |||
| } | |||
| }, | |||
| "platformVersion": "1.0.0", | |||
| "platformVersion": "6.13.0", | |||
There was a problem hiding this comment.
This should be mocked so we don't need to update this for every release.
Mrtenz
previously approved these changes
Dec 10, 2024
Mrtenz
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2803 we added support for
platformVersionin the manifest to indicate what version of the platform the Snap was implemented for. We chose to not automatically add this version to the manifest before releasing the initial changes. Since those changes have now been released we can enable automatically adding the field to the manifest.Closes #2854