Add onSettingsPage export
#2911
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2911 +/- ##
==========================================
+ Coverage 94.49% 94.50% +0.01%
==========================================
Files 487 488 +1
Lines 10450 10472 +22
Branches 1604 1608 +4
==========================================
+ Hits 9875 9897 +22
Misses 575 575 ☔ View full report in Codecov by Sentry. |
GuillaumeRx
force-pushed
the
gr/on-settings-page
branch
from
f2afbf9 to
10d2afb
Compare
packages/test-snaps/src/features/snaps/settings-page/SettingsPage.tsx
Outdated
Show resolved
Hide resolved
packages/test-snaps/src/features/snaps/settings-page/constants.ts
Outdated
Show resolved
Hide resolved
GuillaumeRx
force-pushed
the
gr/on-settings-page
branch
from
10d2afb to
fa382b6
Compare
| @@ -0,0 +1,23 @@ | |||
| { | |||
There was a problem hiding this comment.
This file will need updating after a rebase
| content: ( | ||
| <Box> | ||
| <Heading>Hello world!</Heading> | ||
| <Text>Welcome to my Snap settings page!</Text> |
There was a problem hiding this comment.
Can we add a toggle or something to show how one would build a settings page and save the data from it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
onSettingsPageexport that is used to display custom UI.Fixes: #2874