Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Remove unnecessary proxy for provider globals #2850

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

FrederikBolding
Copy link
Member

Removes unnecessary proxy wrapping of provider globals to reduce complexity and overhead.

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.48%. Comparing base (96a29cb) to head (aab2df6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2850      +/-   ##
==========================================
- Coverage   94.49%   94.48%   -0.02%     
==========================================
  Files         486      486              
  Lines       10404    10399       -5     
  Branches     1596     1594       -2     
==========================================
- Hits         9831     9825       -6     
- Misses        573      574       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@FrederikBolding FrederikBolding force-pushed the fb/remove-unnecesary-proxy branch from 3d77de8 to ecb5ba6 Compare October 25, 2024 10:11
@FrederikBolding FrederikBolding force-pushed the fb/remove-unnecesary-proxy branch from ecb5ba6 to 9b54642 Compare November 19, 2024 09:51
@FrederikBolding FrederikBolding marked this pull request as ready for review November 19, 2024 13:37
@FrederikBolding FrederikBolding requested a review from a team as a code owner November 19, 2024 13:37
naugtur
naugtur previously approved these changes Nov 19, 2024
Copy link

@naugtur naugtur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see issues with doing this.

Mrtenz
Mrtenz previously approved these changes Nov 19, 2024
@FrederikBolding FrederikBolding dismissed stale reviews from Mrtenz and naugtur via aab2df6 November 19, 2024 14:59
@FrederikBolding FrederikBolding force-pushed the fb/remove-unnecesary-proxy branch from 9b54642 to aab2df6 Compare November 19, 2024 14:59
@FrederikBolding FrederikBolding merged commit 5052aaa into main Nov 19, 2024
166 checks passed
@FrederikBolding FrederikBolding deleted the fb/remove-unnecesary-proxy branch November 19, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants