-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Checkbox component #2501
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrederikBolding
force-pushed
the
fb/checkbox-component
branch
2 times, most recently
from
June 20, 2024 12:33
84787dd
to
14e2933
Compare
Mrtenz
requested changes
Jun 20, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2501 +/- ##
=======================================
Coverage 94.39% 94.40%
=======================================
Files 441 442 +1
Lines 9109 9125 +16
Branches 1405 1411 +6
=======================================
+ Hits 8598 8614 +16
Misses 511 511 ☔ View full report in Codecov by Sentry. |
Mrtenz
approved these changes
Jun 25, 2024
FrederikBolding
force-pushed
the
fb/checkbox-component
branch
from
June 25, 2024 09:14
211e95b
to
ba5e072
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a checkbox component, that can be nested in a
Field
or used separately.Breaking: Since the checkbox component uses a
boolean
for its state,FormSubmitEvent
andInputChangeEvent
can now contain boolean values.If no initial value is given to the checkbox, it will default to
false
.Progresses #2500