Bump MetaMask core packages #1818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: @metamask/[email protected] |
FrederikBolding
changed the title
This was referenced Oct 5, 2023
jiexi
reviewed
Oct 5, 2023
| @@ -68,7 +68,7 @@ export const getLocaleBuilder = Object.freeze({ | |||
| */ | |||
| export function getImplementation({ getLocale }: GetLocaleMethodHooks) { | |||
| return async function implementation( | |||
| _args: RestrictedMethodOptions<void>, | |||
| _args: RestrictedMethodOptions<any>, | |||
There was a problem hiding this comment.
This one is a bit difficult, I'm not sure what we we should type this as since we don't use the arguments at all. Any was the best I could come up with, but I don't think it should matter much since the arguments are discarded.
There was a problem hiding this comment.
Doesn't work, but RestrictedMethodParameters does.
jiexi
reviewed
Oct 5, 2023
.yarn/patches/@esbuild-plugins-node-modules-polyfill-npm-0.2.2-f612681798.patch
Show resolved
Hide resolved
jiexi
reviewed
Oct 5, 2023
| @@ -399,7 +397,7 @@ export abstract class AbstractExecutionService<WorkerType> | |||
| handler, | |||
| request, | |||
| target: snapId, | |||
| }, | |||
| } as Record<string, Json>, | |||
There was a problem hiding this comment.
I'm guessing params is causing grief here? if so, could we move the type assertion to params?
There was a problem hiding this comment.
It is in fact request that is typed as Record<string, Json> but should be a JsonRpcRequest by the time we get here. I have moved the cast.
jiexi
reviewed
Oct 5, 2023
FrederikBolding
force-pushed
the
fb/bump-json-rpc-engine-et-all
branch
from
9f2ef29
to
bb2dcbd
Compare
Mrtenz
added a commit
that referenced
this pull request
Oct 11, 2023
This fixes the Snaps controllers and execution environments tests on #1818.
This fixes the Snaps controllers and execution environments tests on
FrederikBolding
force-pushed
the
fb/bump-json-rpc-engine-et-all
branch
from
8c9ba92
to
8b0ed91
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## feat/error-handling #1818 +/- ##
=======================================================
- Coverage 95.98% 95.97% -0.02%
=======================================================
Files 241 241
Lines 5586 5592 +6
Branches 877 881 +4
=======================================================
+ Hits 5362 5367 +5
- Misses 224 225 +1
☔ View full report in Codecov by Sentry. |
Mrtenz
approved these changes
Oct 11, 2023
FrederikBolding
merged commit cbf0102
into
feat/error-handling
132 of 134 checks passed
Mrtenz
added a commit
that referenced
this pull request
Oct 17, 2023
Rebased and updated version of #1728 - Updates and uses `@metamask/rpc-errors` everywhere - Updates and uses `@metamask/json-rpc-engine` everywhere - Updates the following packages to latest: `@metamask/permission-controller`, `@metamask/approval-controller`, `@metamask/providers`, `@metamask/eth-json-rpc-middleware` Huge thank you to @legobeat for all of the help landing this ❤️ Blocked by #1823 --------- Co-authored-by: legobt <[email protected]> Co-authored-by: Maarten Zuidhoorn <[email protected]>
Mrtenz
added a commit
that referenced
this pull request
Oct 19, 2023
Rebased and updated version of #1728 - Updates and uses `@metamask/rpc-errors` everywhere - Updates and uses `@metamask/json-rpc-engine` everywhere - Updates the following packages to latest: `@metamask/permission-controller`, `@metamask/approval-controller`, `@metamask/providers`, `@metamask/eth-json-rpc-middleware` Huge thank you to @legobeat for all of the help landing this ❤️ Blocked by #1823 --------- Co-authored-by: legobt <[email protected]> Co-authored-by: Maarten Zuidhoorn <[email protected]>
Mrtenz
added a commit
that referenced
this pull request
Oct 20, 2023
Rebased and updated version of #1728 - Updates and uses `@metamask/rpc-errors` everywhere - Updates and uses `@metamask/json-rpc-engine` everywhere - Updates the following packages to latest: `@metamask/permission-controller`, `@metamask/approval-controller`, `@metamask/providers`, `@metamask/eth-json-rpc-middleware` Huge thank you to @legobeat for all of the help landing this ❤️ Blocked by #1823 --------- Co-authored-by: legobt <[email protected]> Co-authored-by: Maarten Zuidhoorn <[email protected]>
Merged
Mrtenz
added a commit
that referenced
this pull request
Oct 20, 2023
This improves error handling by: - Using `@metamask/rpc-errors` instead of `eth-rpc-errors` throughout the entire stack. - Introducing a new `SnapError`, which will not cause the Snap to crash when thrown. - Unwrapping errors where possible. - Also bumps a ton of MetaMask dependencies, see #1818 --------- Co-authored-by: Frederik Bolding <[email protected]> Co-authored-by: legobt <[email protected]>
benefacto
pushed a commit
to zenchain-protocol/zazen
that referenced
this pull request
Jul 3, 2024
This improves error handling by: - Using `@metamask/rpc-errors` instead of `eth-rpc-errors` throughout the entire stack. - Introducing a new `SnapError`, which will not cause the Snap to crash when thrown. - Unwrapping errors where possible. - Also bumps a ton of MetaMask dependencies, see MetaMask/snaps#1818 --------- Co-authored-by: Frederik Bolding <[email protected]> Co-authored-by: legobt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased and updated version of #1728
@metamask/rpc-errorseverywhere@metamask/json-rpc-engineeverywhere@metamask/permission-controller,@metamask/approval-controller,@metamask/providers,@metamask/eth-json-rpc-middlewareHuge thank you to @legobeat for all of the help landing this ❤️
Blocked by #1823