Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LavaMoat #1754

Merged
merged 2 commits into from
Sep 22, 2023
Merged

Update LavaMoat #1754

merged 2 commits into from
Sep 22, 2023

Conversation

david0xd
Copy link
Contributor

@david0xd david0xd commented Sep 19, 2023

Update all lavamoat packages to latest version.

yarn up: @lavamoat/allow-scripts, @lavamoat/lavapack, lavamoat, lavamoat-browserify.
yarn dedupe
yarn build:lavamoat:policy
Re-apply patches.
Removed old version patches.

{
    "@lavamoat/allow-scripts": "^2.5.1",
    "@lavamoat/lavapack": "^5.4.1",
    "lavamoat": "^7.3.1",
    "lavamoat-browserify": "^15.9.1",
}

@david0xd david0xd self-assigned this Sep 19, 2023
@socket-security
Copy link

Updated and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@lavamoat/lavapack 5.2.1...5.4.1 None +0/-40 462 kB boneskull
lavamoat 7.0.0...7.3.1 None +2/-42 76.5 kB boneskull
lavamoat-browserify 15.7.1...15.9.1 None +4/-44 1 MB boneskull

🚮 Removed packages: @babel/[email protected], @lavamoat/[email protected], [email protected]

@socket-security
Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Issue Package Version Note Source
New author @lavamoat/aa 3.1.5
Unstable ownership @lavamoat/aa 3.1.5
Unstable ownership @lavamoat/lavapack 5.4.1
Unstable ownership lavamoat 7.3.1
Unstable ownership lavamoat-browserify 15.9.1

Next steps

What is new author?

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

What is unstable ownership?

A new collaborator has begun publishing package versions. Package stability and security risk may be elevated.

Try to reduce the amount of authors you depend on to reduce the risk to malicious actors gaining access to your supply chain. Packages should remove inactive collaborators with publishing rights from packages on npm.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

Copy link
Member

@FrederikBolding FrederikBolding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is ready to go as soon as we rebase and reapply the patches!

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (080d211) 95.84% compared to head (8c4b7b8) 95.84%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1754   +/-   ##
=======================================
  Coverage   95.84%   95.84%           
=======================================
  Files         239      239           
  Lines        5465     5465           
  Branches      851      851           
=======================================
  Hits         5238     5238           
  Misses        227      227           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@david0xd david0xd marked this pull request as ready for review September 22, 2023 08:44
@david0xd david0xd requested a review from a team as a code owner September 22, 2023 08:44
@FrederikBolding
Copy link
Member

@SocketSecurity ignore @lavamoat/[email protected]
@SocketSecurity ignore @lavamoat/[email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]

All of these are fine

@FrederikBolding FrederikBolding changed the title Update lavamoat Update LavaMoat Sep 22, 2023
Copy link
Member

@FrederikBolding FrederikBolding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@david0xd david0xd merged commit 62d4e5d into main Sep 22, 2023
134 checks passed
@david0xd david0xd deleted the dd/update-lavamoat branch September 22, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants