Add harden events utilities #1221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weizman
previously approved these changes
Feb 22, 2023
david0xd
force-pushed
the
dd/harden-events
branch
from
dd92974 to
83a8171
Compare
david0xd
force-pushed
the
dd/harden-events
branch
2 times, most recently
from
b9ded0e to
8dae818
Compare
david0xd
force-pushed
the
dd/harden-events
branch
from
59b39bf to
816847d
Compare
weizman
reviewed
Mar 2, 2023
packages/snaps-controllers/src/services/iframe/IframeExecutionService.test.browser.ts
Outdated
Show resolved
Hide resolved
weizman
reviewed
Mar 2, 2023
packages/snaps-controllers/src/services/iframe/IframeExecutionService.test.browser.ts
Outdated
Show resolved
Hide resolved
weizman
reviewed
Mar 2, 2023
packages/snaps-controllers/src/services/iframe/test/event-test.js
Outdated
Show resolved
Hide resolved
weizman
reviewed
Mar 2, 2023
packages/snaps-controllers/src/services/iframe/test/events.html
Outdated
Show resolved
Hide resolved
weizman
reviewed
Mar 2, 2023
packages/snaps-execution-environments/src/common/lockdown/lockdown-events.ts
Outdated
Show resolved
Hide resolved
weizman
reviewed
Mar 2, 2023
packages/snaps-execution-environments/src/common/lockdown/lockdown-events.ts
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #1221 +/- ##
==========================================
+ Coverage 95.30% 95.62% +0.32%
==========================================
Files 141 140 -1
Lines 4383 4388 +5
Branches 718 725 +7
==========================================
+ Hits 4177 4196 +19
+ Misses 206 192 -14
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
david0xd
force-pushed
the
dd/harden-events
branch
from
c413012 to
f4458df
Compare
Mrtenz
reviewed
Mar 8, 2023
packages/snaps-execution-environments/src/common/lockdown/lockdown-events.ts
Outdated
Show resolved
Hide resolved
Mrtenz
reviewed
Mar 8, 2023
packages/snaps-controllers/src/services/iframe/IframeExecutionService.test.browser.ts
Show resolved
Hide resolved
packages/snaps-controllers/src/services/iframe/IframeExecutionService.test.browser.ts
Show resolved
Hide resolved
packages/snaps-execution-environments/src/common/lockdown/lockdown-events.test.browser.ts
Outdated
Show resolved
Hide resolved
david0xd
force-pushed
the
dd/harden-events
branch
from
2ff7c81 to
0a4b5d2
Compare
FrederikBolding
requested changes
Mar 9, 2023
packages/snaps-execution-environments/src/node-process/index.ts
Outdated
Show resolved
Hide resolved
Change lockdown execution order WIP: Experimental testing (for debugging purposes only) Update with version of code that will work after updating post-message-stream Add review refactoring (1) Add review refactoring (2) Add review refactoring (3) Update post-message-stream version and add test to improve coverage Fix coverage after rebase Try to fix coverage Refactor lockdown-events.ts Fix yarn conflicts after rebase Refactor test for events lockdown function Add lockdown events in other environments Revert "Add lockdown events in other environments" This reverts commit 4e89e4e. Add new proposal for implementing lockdown of events Fix coverage issues
david0xd
force-pushed
the
dd/harden-events
branch
from
e25a8be to
8f54c08
Compare
weizman
approved these changes
Mar 15, 2023
FrederikBolding
approved these changes
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1132
This PR will add utility functions with procedures for hardening Event related objects.
New lockdown procedure file is added exclusively for events
lockdown-events.tsexporting functionexecuteLockdownEventsthat is called inpackages/snaps-execution-environments/src/iframe/index.tsbefore other lockdown functions to ensure that this one will be executed before SES disallows further changes.Currently blocked by (depends on): MetaMask/post-message-stream#79