Remove endowment:long-running #1751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1751 +/- ##
==========================================
+ Coverage 95.79% 95.82% +0.02%
==========================================
Files 240 239 -1
Lines 5476 5464 -12
Branches 852 851 -1
==========================================
- Hits 5246 5236 -10
+ Misses 230 228 -2
☔ View full report in Codecov by Sentry. |
This was referenced Sep 19, 2023
david0xd
force-pushed
the
dd/remove-endowment-long-running
branch
from
d194a56 to
a14b4cc
Compare
GuillaumeRx
previously approved these changes
Sep 20, 2023
FrederikBolding
previously approved these changes
Sep 20, 2023
david0xd
dismissed stale reviews from FrederikBolding and GuillaumeRx
via
1fd2373
david0xd
force-pushed
the
dd/remove-endowment-long-running
branch
2 times, most recently
from
1fd2373 to
8ec7034
Compare
FrederikBolding
requested changes
Sep 21, 2023
FrederikBolding
approved these changes
Sep 21, 2023
david0xd
force-pushed
the
dd/remove-endowment-long-running
branch
from
8ec7034 to
e7c53a9
Compare
david0xd
added a commit
to MetaMask/metamask-extension
that referenced
this pull request
Sep 27, 2023
## **Description** This PR removes `long-running` Snap endowment/permission. Snaps team have decided to remove this endowment because of its unpredictable security concerns around running Snaps indefinitely. This endowment is removed in favor of the new endowments that will be focused on solving certain use cases that require snap to be running for more time than default. ## **Related issues** _Fixes [#945](MetaMask/snaps#945 ## **Related PR** MetaMask/snaps#1751 (**required**) MetaMask/metamask-docs#919 ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've clearly explained: - [ ] What problem this PR is solving. - [ ] How this problem was solved. - [ ] How reviewers can test my changes. - [ ] I’ve indicated what issue this PR is linked to: Fixes #??? - [ ] I’ve included tests if applicable. - [ ] I’ve documented any added code. - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). - [ ] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #945
This PR will remove the existence of the
long-runningendowment.Related
metamask-extensionPR: MetaMask/metamask-extension#20951Documentation update PR: MetaMask/metamask-docs#919