[FLASK] Remove endowment:long-running from documentation #919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview published: dd/remove-endowment-long-running |
This was referenced Sep 19, 2023
Montoya
approved these changes
Sep 19, 2023
alexandratran
approved these changes
Sep 19, 2023
david0xd
added a commit
to MetaMask/metamask-extension
that referenced
this pull request
Sep 27, 2023
## **Description** This PR removes `long-running` Snap endowment/permission. Snaps team have decided to remove this endowment because of its unpredictable security concerns around running Snaps indefinitely. This endowment is removed in favor of the new endowments that will be focused on solving certain use cases that require snap to be running for more time than default. ## **Related issues** _Fixes [#945](MetaMask/snaps#945 ## **Related PR** MetaMask/snaps#1751 (**required**) MetaMask/metamask-docs#919 ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've clearly explained: - [ ] What problem this PR is solving. - [ ] How this problem was solved. - [ ] How reviewers can test my changes. - [ ] I’ve indicated what issue this PR is linked to: Fixes #??? - [ ] I’ve included tests if applicable. - [ ] I’ve documented any added code. - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). - [ ] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes documentation related to the
long-runningendowment permission.Related ticket:
MetaMask/snaps#945
Related PR:
MetaMask/metamask-extension#20951
MetaMask/snaps#1751