Refactor test for events lockdown function

MetaMask · Mar 9, 2023 · bad541d · bad541d
1 parent 0a4b5d2
commit bad541d
Showing 1 changed file with 9 additions and 9 deletions.
diff --git a/packages/snaps-execution-environments/src/common/lockdown/lockdown-events.test.browser.ts b/packages/snaps-execution-environments/src/common/lockdown/lockdown-events.test.browser.ts
@@ -7,19 +7,19 @@ describe('lockdown events security', () => {
   it('should lockdown events and made event properties inaccessible', async () => {
     executeLockdownEvents();
 
-    let resolvePromise: (value: unknown) => void;
+    const eventTarget = new EventTarget();
+
     const promise = new Promise((resolve) => {
-      resolvePromise = resolve;
+      eventTarget.addEventListener('just-test-event', (eventObject) => {
+        // eslint-disable-next-line @typescript-eslint/unbound-method
+        resolve(eventObject.composedPath);
+      });
     });
 
-    const eventTarget = new EventTarget();
-    eventTarget.addEventListener('just-test-event', (eventObject) => {
-      // eslint-disable-next-line @typescript-eslint/unbound-method
-      expect(eventObject.composedPath).toBeUndefined();
-      resolvePromise(true);
-    });
     const testEvent = new Event('just-test-event');
     eventTarget.dispatchEvent(testEvent);
-    await promise;
+
+    const result = await promise;
+    expect(result).toBeUndefined();
   });
 });