Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Snap allowlist process issue templates #83

Merged
merged 14 commits into from
Sep 6, 2023
Merged

Conversation

kenhkan
Copy link
Contributor

@kenhkan kenhkan commented Sep 6, 2023

No description provided.

@kenhkan kenhkan requested a review from a team as a code owner September 6, 2023 15:26
@kenhkan kenhkan changed the title Add Snap allowlist process issue templates [WIP] Add Snap allowlist process issue templates Sep 6, 2023
@kenhkan kenhkan requested a review from Montoya September 6, 2023 19:16
Montoya
Montoya previously approved these changes Sep 6, 2023
Copy link
Contributor

@Montoya Montoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have been tasked with documenting our process for allowlisting Snaps and I think it is best to use the issues in the repository itself. Will start using this right away.

Copy link
Member

@Mrtenz Mrtenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits, some suggestions.

.github/ISSUE_TEMPLATE/block-snap.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/new-snap.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/remove-snap.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/update-snap.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/block-snap.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/new-snap.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/remove-snap.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/update-snap.md Outdated Show resolved Hide resolved

Note: Blocking a Snap means that both new and existing users cannot use the Snap.

All items in the list below needs to be satisfied.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would move this below the "Checklist" header, but this is ok too.

@kenhkan kenhkan changed the title [WIP] Add Snap allowlist process issue templates Add Snap allowlist process issue templates Sep 6, 2023
@kenhkan kenhkan merged commit b9b48e0 into main Sep 6, 2023
21 checks passed
@kenhkan kenhkan deleted the snap-allowlist-process branch September 6, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants