Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use noble-hashes and noble-curves #315

Merged
merged 5 commits into from
Dec 7, 2023

Conversation

FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Dec 7, 2023

Use noble-hashes for SHA256 instead of the utility function from @noble/secp256k1 since the existing code is not compatible with React Native. Use noble-curves as that still supports CommonJS.

@FrederikBolding FrederikBolding requested a review from a team as a code owner December 7, 2023 10:57
@FrederikBolding FrederikBolding changed the title Use noble-hashes for SHA256 Use noble-hashes and noble-curves Dec 7, 2023
@FrederikBolding FrederikBolding force-pushed the fb/use-noble-hashes-for-sha256 branch from a868f2f to e79f965 Compare December 7, 2023 11:19
@FrederikBolding FrederikBolding merged commit 12dc0b0 into main Dec 7, 2023
14 checks passed
@FrederikBolding FrederikBolding deleted the fb/use-noble-hashes-for-sha256 branch December 7, 2023 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants