Add script for signing, verifying, and deploying registry #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mrtenz
force-pushed
the
mrtenz/sign-registry
branch
from
2ceea77 to
5673658
Compare
Mrtenz
changed the title
There was a problem hiding this comment.
Code here looks good to me. A few questions about whether this is the direction we should go or not. Will leave them to @ritave
scripts/verify-registry.ts
Outdated
| * The `PUBLIC_KEY` environment variable must be set to the public key of the | ||
| * private key that was used to sign the registry. | ||
| */ | ||
| async function main() { |
There was a problem hiding this comment.
This should probably go into snaps-utils so we can use it in the SnapController to verify.
There was a problem hiding this comment.
Unless we manually sign, then this is a good check for CI to do.
ritave
previously approved these changes
Mar 24, 2023
ritave
approved these changes
Mar 24, 2023
ritave
previously approved these changes
Mar 24, 2023
ritave
approved these changes
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds two new scripts:
yarn sign: Signs the registry with the givenPRIVATE_KEYenvironment variable, and writes the signature tosrc/signature.json.yarn verify: Verifies the signature with the givenPUBLIC_KEYenvironment variable.It also adds a workflow which will run on commits to main (not on PRs), which checks if the
registry.jsonwas updated, and will deploy it togh-pagesif so.fixes: https://github.com/MetaMask/MetaMask-planning/issues/377