chore: Remove unnecessary events dependency
#473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: npm/[email protected] |
mcmire
approved these changes
Dec 4, 2024
cryptodev-2s
approved these changes
Dec 4, 2024
This dependency was not used anywhere. Previously it was brought in because an older version of this controller extended `EventEmitter`, but even then the package wasn't really used (the Node.js events module was resolved instead). We're not even using `EventEmitter` anymore since the migration to the `BaseControllerV2` base class.
Gudahtt
force-pushed
the
remove-unnecessary-events-dependency
branch
from
6bd0ebe to
d111fdb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This dependency was not used anywhere. Previously it was brought in because an older version of this controller extended
EventEmitter, but even then the package wasn't really used (the Node.js events module was resolved instead).We're not even using
EventEmitteranymore since the migration to theBaseControllerV2base class.