Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Wallet Discovery For Multichain API #2970 #395

Merged
merged 9 commits into from
Dec 13, 2024
Merged

Implement Wallet Discovery For Multichain API #2970 #395

merged 9 commits into from
Dec 13, 2024

Conversation

ffmcgee725
Copy link
Member

Addressing Implement Wallet Discovery For Multichain API #2970

feat: support CAIP294 (standardized messaging transport for browser extension wallets)

feat: make sure we pass in extensionId when announcing wallet

@ffmcgee725 ffmcgee725 requested a review from a team as a code owner December 10, 2024 10:36
@ffmcgee725
feat: support CAIP294 (standardized messaging transport for browser e…
b3e4754 
…xtension wallets)

feat: make sure we pass in extensionId when announcing wallet
jiexi
jiexi reviewed Dec 10, 2024
View reviewed changes
src/EIP6963.ts Outdated Show resolved Hide resolved
jiexi
jiexi reviewed Dec 10, 2024
View reviewed changes
src/CAIP294.ts Show resolved Hide resolved
jiexi
jiexi reviewed Dec 10, 2024
View reviewed changes
src/CAIP294.ts Show resolved Hide resolved
jiexi
jiexi reviewed Dec 10, 2024
View reviewed changes
src/CAIP294.ts Show resolved Hide resolved
@ffmcgee725 ffmcgee725 requested a review from adonesky1 December 11, 2024 09:42
jiexi
jiexi reviewed Dec 12, 2024
View reviewed changes
src/CAIP294.ts Outdated Show resolved Hide resolved
@ffmcgee725 ffmcgee725 requested a review from jiexi December 12, 2024 20:44
jiexi
jiexi previously approved these changes Dec 12, 2024
View reviewed changes
@ffmcgee725 ffmcgee725 merged commit 53e3f81 into main Dec 13, 2024
18 checks passed
@ffmcgee725 ffmcgee725 deleted the jc/caip-294-poc branch December 13, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiexi jiexi jiexi approved these changes

@adonesky1 adonesky1 Awaiting requested review from adonesky1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ffmcgee725 @jiexi @adonesky1