Use addEventListener instead of onmessage in WebWorkerPostMessageStream
#83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…am constructor The use of addEventListener allows proper handling of multiple event listeners. onmesssage also does not work with LavaMoat.
rekmarks
reviewed
Mar 31, 2023
This test is now unnecessary.
Mrtenz
changed the title
addEventListener instead of onmessage in WebWorkerPostMessageStreaaddEventListener instead of onmessage in WebWorkerPostMessageStream
The test was trying to use globalThis.self variable, but it is not always defined in the test environment. To fix the issue, the variable can be created as a mock object before each test, and restored to the original value after it finishes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request updates the
WebWorkerPostMessageStreamconstructor to use theaddEventListenermethod insteadof
onmessage. The use ofaddEventListenerallows for proper handling of multiple event listeners and making theevent handling process more robust. It also ensures that the code is compatible with LavaMoat.
The
WebWorkerPostMessageStreamis used in our project for communication between web workers in our application. Thestream constructor uses
postMessageandonmessageto emit and receive messages, respectively. Theonmessagemethod is used to handle incoming messages from multiple listeners. However, this method doesn't provide easy
management of event listeners. In this pull request, we change the constructor code to use
addEventListenerwhichis more versatile and makes the code more maintainable.
This change will not have a significant impact on the performance of the application, but it makes the code more
readable and safer to maintain.
Changes
WebWorkerPostMessageStreamconstructor to useaddEventListenerinstead ofonmessage.