Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dummy "main" script #6

Merged
merged 3 commits into from
May 11, 2022
Merged

Add dummy "main" script #6

merged 3 commits into from
May 11, 2022

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented May 11, 2022

A main script has been added that throws an error if you try to use it. This makes it easier to determine the package location using require.resolve in other packages (it requires there to be a main module).

A main script has been added that throws an error if you try to use it.
This makes it easier to determine the package location using
`require.resolve` in other packages (it requires there to be a main
module).
@Gudahtt Gudahtt requested a review from a team as a code owner May 11, 2022 15:22

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Contributor

@adonesky1 adonesky1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds right to me!

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@Gudahtt Gudahtt merged commit c7f142e into main May 11, 2022
@Gudahtt Gudahtt deleted the add-dummy-main-script branch May 11, 2022 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants