Phishing warning page update more CSS suggestions #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apologies @aleksandar-mihajlovic I can't seem to base this PR onto your branch. But that is my intention. Maybe you could copy and paste the updates from this PR? This is commit with the updates ad6abc5 |
|
The updates in this PR have been successfully ported over to #52 |
georgewrmarshall
deleted the
phishing-warning-page-update-george-suggestions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE TO
mainDescriptions
Some more updates built on New design for phishing warning page PR #52. The intention is for the updates in this commit ad6abc5 to be based on the original PR #52 but I'm not sure how to do that seeing as it's a forked branch.
Screenshots
Before
before.mov
After
phishing.updates.mov
Manual Testing Steps
45to import the design-token.css from the npm packgehref="./design-tokens.css"tohref="../node_modules/@metamask/design-tokens/src/css/design-tokens.css"