Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gh-pages publishing #25

Merged
merged 1 commit into from
Jul 12, 2022
Merged

Fix gh-pages publishing #25

merged 1 commit into from
Jul 12, 2022

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Jul 12, 2022

The gh-pages actions were not triggering because they are triggered by a tag. The tag was being added by GitHub actions, so the trigger failed because GitHub actions ignores self-initiated events.

A personal access token belonging to the metamaskbot account has been added to this repository as a secret. This allows us to tag using the bot's account, ensuring the later triggers work correctly.

Fixes #13

The `gh-pages` actions were not triggering because they are triggered
by a tag. The tag was being added by GitHub actions, so the trigger
failed because GitHub actions ignores self-initiated events.

A personal access token belonging to the `metamaskbot` account has been
added to this repository as a secret. This allows us to tag using the
bot's account, ensuring the later triggers work correctly.

Fixes #13
@Gudahtt Gudahtt marked this pull request as ready for review July 12, 2022 17:20
@Gudahtt Gudahtt requested a review from a team as a code owner July 12, 2022 17:20
@Gudahtt
Copy link
Member Author

Gudahtt commented Jul 12, 2022

I created a fork to test this, and it seems to work! https://github.com/Gudahtt/phishing-warning-fork/runs/7306887389?check_suite_focus=true

Copy link
Contributor

@adonesky1 adonesky1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gudahtt Gudahtt merged commit c023169 into main Jul 12, 2022
@Gudahtt Gudahtt deleted the fix-gh-pages-publishing branch July 12, 2022 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix gh-pages release publishing
2 participants