Update GItHub Pages Deployment Token #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request updates the GitHub pages deployment token used to be that belonging to the MetaMaskBot rather than the write token provided by the deploy action. This allows us to have finder control over modifications to the branch.
In addition, i've removed two actions that existed to perform backfills for vulnerabilities affecting a range of phishing-warning page versions. Rather than migrating them to leverage this new token, I have opted for removal as they are no longer relevant, and can be restored if needed.
After Merge
Once merged, please perform a test deployment to make sure everything is working as expected. Please reach out if there are any issues.