-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixup and split backporting actions #137
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we forsee the need to do backports separately like this in the future? Perhaps we can keep a single action and just add a suffix to the git branch name (e.g add on BASE_REF) to avoid the issue from before.
git branch -D "gh-pages-backport-${{env.BASE_REF}}"
I think so yes, 2.0.1 and 2.1.0 are not compatible and that is why I kept it as separate actions, single action is also blocking by requiring second PR for different version. |
Got it, we can proceed with it as two separate for now as there is no harm in doing so |
rm bad version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
split backporting action as they were using same end branch and to indicate incompatibility between >2.0.1 and 2.1.0+