Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streams API v3 #122

Merged
merged 4 commits into from
Nov 7, 2023
Merged

Streams API v3 #122

merged 4 commits into from
Nov 7, 2023

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Nov 7, 2023

  • Consolidate all runtime use of streams on streams API 3 via [email protected].
    • deps: obj-multiplex@^1.0.0 -> @metamask/object-multiplex@^2.0.0
    • Replace dependency pump with equivalent function pipeline from readable-stream
  • Some use of [email protected] still remains in devDependencies, notably through browserify.

Related

@legobeat legobeat requested a review from a team as a code owner November 7, 2023 01:18
@legobeat legobeat requested a review from brad-decker November 7, 2023 01:18
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@metamask/object-multiplex 2.0.0 None +0 13.2 kB lgbot

🚮 Removed packages: @types/[email protected], @types/[email protected], [email protected], [email protected], [email protected]

Copy link

socket-security bot commented Nov 7, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: @metamask/[email protected]

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

@legobeat
Copy link
Contributor Author

legobeat commented Nov 7, 2023

@SocketSecurity ignore @metamask/[email protected]

ownership ok

@legobeat legobeat merged commit 2496aa9 into MetaMask:main Nov 7, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants