New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: readable-stream@^3.6.2->^4.5.2 #111

Draft

legobeat wants to merge 5 commits into MetaMask:main from legobeat:readable-stream-4

Contributor

legobeat commented May 15, 2024 •

edited

Loading

Updates Streams API to correspond to contemporary Node versions (v18) rather than Nodejs v10.

BREAKING: deps: Upgrade readable-stream from ^3.6.2 to latest ^4.5.2
- chore(devDeps): Add @types/readable-stream

Related

See also: deps: readable-stream@^3.6.2->^4.5.2 object-multiplex#51

Blocked by

feat: Allow overriding default Stream options #110

legobeat added 5 commits

May 15, 2024 03:04


          chore(devDeps): add @types/readable-stream

ec1db7c

- @types/readable-stream v3 does not exist
- @types/readable-stream 4.0.0 maps to v3 except missing function
- @types/readable-stream >4.0.0 not compatible with readable-stream v3


          fix: update @types/node from v10 to v14

42f53fd


          feat: allow overriding stream constructor options in storeTransformSt…

4b0dcd7

…ream


          feat: allow overriding stream constructor options for ObservableStore…

d3e5052

…Stream


          deps: readable-stream@^3.6.2->^4.5.2

6421ce0

legobeat requested a review from a team as a code owner

May 15, 2024 03:39

legobeat marked this pull request as draft

May 15, 2024 03:39

socket-security bot commented May 15, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@types/[email protected]	None	`0`	1.61 MB	types
npm/@types/[email protected]	None	`+1`	63.3 kB	types
npm/[email protected]	environment	`+7`	688 kB	matteo.collina
npm/[email protected]	None	`0`	73.1 kB	ethan_arrowood

🚮 Removed packages: npm/@types/[email protected]

View full report↗︎

Contributor Author

legobeat commented May 16, 2024 •

edited

Loading

Personally putting this on hold until we have resolved the test error in unrelated deps: readable-stream@^3.6.2->^4.5.2 object-multiplex#51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet