feat: smart tx small views #9448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
3 tasks
infiniteflower
force-pushed
the
feat/smart-tx-small-logic
branch
from
1648c4c to
2196f72
Compare
infiniteflower
force-pushed
the
feat/smart-tx-small-views
branch
from
2a4f691 to
45a082d
Compare
|
Have to get the newest changes from #9565 |
|
infiniteflower
force-pushed
the
feat/smart-tx-small-logic
branch
from
90de053 to
063b3f1
Compare
infiniteflower
dismissed stale reviews from tommasini and vinistevam
The base branch was changed.
infiniteflower
added a commit
that referenced
this pull request
May 16, 2024
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> This PR only covers a smaller subset of the files from #9565 for ease of reviewing. Please refer to that issue for videos. This PR is mostly for the core logical parts of Smart Transactions (STX). This PR can be merged as it won't change any existing behavior in the application without a follow up PR to actually use these utility functions. It covers the following areas 1. `/app/util` - except `app/util/test/initial-background-state.json`, `app/util/transactions/index.js`, `app/util/transactions/index.test.ts` since it causes tests to fail 3. `/app/images` 4. `/e2e/selectors` 5. `app/core/RPCMethods/RPCMethodMiddleware.ts` (to fix tests) 6. `package.json` (Added `smart-transactions-controller` to this PR to fix failing tests) 7. `app/components/Nav/Main/RootRPCMethodsUI.js` to fix failing tests 8. `@metamask+transaction-controller+13.0.0.patch` (https://github.com/MetaMask/core/compare/patch/mobile-transaction-controller-13-0-0-smart-transactions) 9. `yarn.lock` 10. `jest.config.js` ## **Related issues** - Broken out from #9565 - Functionality in this PR enabled in follow-up #9448 ## **Manual testing steps** Refer to #9565 ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> Refer to #9565 ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: tommasini <[email protected]>
tommasini
reviewed
May 16, 2024
tommasini
previously approved these changes
May 16, 2024
vinistevam
previously approved these changes
May 16, 2024
infiniteflower
added
Run Smoke E2E
|
tommasini
previously approved these changes
May 16, 2024
infiniteflower
added
Run Smoke E2E
|
|
|
Links to commented code to remove after QA |
tommasini
approved these changes
May 16, 2024
metamaskbot
added
the
release-7.24.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR only covers a smaller subset of the files from #9565 for ease of reviewing. Please refer to that issue for videos. This PR is mostly for Engine and the views for Smart Transactions (STX). Merging this PR will cause changes to the functionality and behavior of the app, effectively making the feature "live".
It covers the following areas:
app/componentsapp/coreapp/reducersapp/selectorsapp/util/testpatchesPreferencesController(PR here to apply update tomain)SwapsController(PR here to apply updates tomain)Also fixed an issue for network onboarding where it would never set onboarded to
true. This needed to be fixed so we could properly show the STX Opt In Modal. We only show the Opt In modal if the user has onboarded onto the network, to prevent multiple modals from showing up at the same time. See discussion #9448 (comment)Related issues
Fixes: n/a
Manual testing steps
Refer to #9565
Screenshots/Recordings
Refer to #9565
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist