Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/flaky tests issues template skip 2 #9301

Merged
merged 6 commits into from
May 22, 2024
Merged

Fix/flaky tests issues template skip 2 #9301

merged 6 commits into from
May 22, 2024

Conversation

gauthierpetetin
Copy link
Contributor

Description

Tiny adjustments to align with Extension.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@gauthierpetetin gauthierpetetin requested a review from a team as a code owner April 17, 2024 22:07
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@gauthierpetetin gauthierpetetin added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 17, 2024
@gauthierpetetin gauthierpetetin mentioned this pull request Apr 17, 2024
Merged
7 tasks
@chrisleewilcox
Copy link
Contributor

@gauthierpetetin please review merge conflict.

@gauthierpetetin
Copy link
Contributor Author

@chrisleewilcox yes, conflicts are now resolved

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@gauthierpetetin gauthierpetetin merged commit 8592337 into main May 22, 2024
31 checks passed
@gauthierpetetin gauthierpetetin deleted the fix/flaky-tests-issues-template-skip-2 branch May 22, 2024 14:46
@github-actions github-actions bot locked and limited conversation to collaborators May 22, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label May 22, 2024
@metamaskbot metamaskbot added the release-7.24.0 Issue or pull request that will be included in release 7.24.0 label May 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@legobeat legobeat legobeat left review comments

@MarioAslau MarioAslau MarioAslau approved these changes

@chrisleewilcox chrisleewilcox Awaiting requested review from chrisleewilcox

Assignees
No one assigned
Labels
release-7.24.0 Issue or pull request that will be included in release 7.24.0 team-mobile-platform
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gauthierpetetin @chrisleewilcox @MarioAslau @legobeat @metamaskbot