Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: SES lockdown v0.18.8 (iOS JSC) #6586
feat: SES lockdown v0.18.8 (iOS JSC) #6586
Changes from 81 commits
7ac4040
8c1b278
4c205b4
191b45e
4469470
0f2f915
4f9a849
00dd1ac
991c926
3aba797
e1e99eb
a4229b0
873716b
745d89a
0c542c9
b635b1c
15a8ab7
22bde3a
8186199
401b41f
d2d2bf4
e52f13a
28b9db4
243d895
76cc6e7
9d85f38
3436f11
25c832b
d3ce192
237e804
165b444
2f78412
f5de5eb
e1fbcc0
ed4f49e
ed36668
e0d5b1b
b239c69
0286dfc
5d473a2
049a6f8
337d3b8
24d1d30
8aeb392
c5b5c23
5b89e9b
310defe
6e252a3
ef28c0c
cd9644a
4dd8e84
300e1ff
a773cd4
ab56846
8904439
d8a4fa5
9363d32
599ab6f
8d27f78
7b28ac5
6cf1e7b
662ec47
f74543a
d8cc393
aa44819
0913a90
930198c
cc3d365
c436a60
95c09fb
812653e
b20341c
7d5a7aa
6461aa2
792c6f8
4904529
ab35ea4
ace8c88
25ac5af
35fb6d5
9b4f859
d88e399
e8eaf91
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious, I don't understand here why we needed to point to the src
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good question ^ these couple ethjs contract/query libs we use (transitively via ethjs) to init our engine service
both optimise their bundles with few Babel runtime helpers (notably regenerator and asyncToGenerator)
both currently incompatible with SES, so using their source code instead is less problematic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so captured the details mentioned here
both in a code comment and issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you considered patching
babel-runtime
andregenerator-runtime
instead? They're used in quite a few packages (including some that we'll be introducing soon to the codebase, like ourethjs-*
forks of packages like this one). It may be easier to fix the problem at the source. The extension already has patches for them to make them SES compatible.