Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable eth sign #5826

Closed
wants to merge 8 commits into from
Closed

Disable eth sign #5826

wants to merge 8 commits into from

Conversation

shanejonas
Copy link
Contributor

Description
Disables eth_sign by default. Users must enable eth_sign through "Advanced Settings"

See #5676 for more information.

Screenshots/Recordings

Screen.Recording.2023-02-23.at.9.48.44.AM.mov

Closes #5676

@shanejonas shanejonas requested a review from a team as a code owner February 23, 2023 14:53
@github-actions
Copy link
Contributor

github-actions bot commented Feb 23, 2023 •
edited
Loading

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@shanejonas
Copy link
Contributor Author

Couldn't find any existing tests for features of the AdvancedSettings component to add to

@BelfordZ
Copy link
Contributor

I have read the CLA Document and I hereby sign the CLA

blackdevelopa
blackdevelopa reviewed Feb 23, 2023
View reviewed changes
ios/Podfile.lock Outdated Show resolved Hide resolved
blackdevelopa
blackdevelopa approved these changes Feb 23, 2023
View reviewed changes
Copy link
Contributor

@blackdevelopa blackdevelopa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Just some small changes: one nitpick, cleaner lint (yarn lint:fix) and snapshot test (yarn run test:unit:components-views -u)

@andrepimenta andrepimenta added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Feb 23, 2023
@sethkfman sethkfman added release-6.2.0 Issue or pull request that will be included in release 6.2.0 team-mobile-client labels Feb 23, 2023
@Cal-L
Copy link
Contributor

Cal-L commented Feb 23, 2023 •
edited
Loading

Let's also include translations either in this PR or follow up with a translations PR. Shoot me a message if you need help - I can walk you through it

Edit: Looks like this will be going out in 6.1.1. Let's do a follow up on translations and track separately

@Cal-L Cal-L added release-6.1.1 Issue or pull request that will be included in release 6.1.1 and removed release-6.2.0 Issue or pull request that will be included in release 6.2.0 labels Feb 24, 2023
@BelfordZ BelfordZ mentioned this pull request Feb 27, 2023
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Mar 3, 2023
@gauthierpetetin gauthierpetetin added the team-mobile-ux DEPRECATED: please use "team-wallet-ux" label instead label Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blackdevelopa blackdevelopa blackdevelopa approved these changes

Assignees
No one assigned
Labels
needs-qa Any New Features that needs a full manual QA prior to being added to a release. release-6.1.1 Issue or pull request that will be included in release 6.1.1 team-mobile-ux DEPRECATED: please use "team-wallet-ux" label instead
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disable eth_sign by default
9 participants
@shanejonas @BelfordZ @Cal-L @blackdevelopa @andrepimenta @chrisleewilcox @gauthierpetetin @sethkfman @cortisiko