[FIX] Slow cold starts, fix unnecessary executions of useEffect #5444
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development & PR Process
release-xx
label to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-review
label when work is completedneeds-qa
label when dev review is completedQA Passed
label when QA has signed offDescription
This PR fixes slow cold start.
There is still a place for improvement since we have a lot of asynchronous functions running when bootstrapping the application, from my discoverings Analytics init and any reads from Async Storage tend to be slow but that's something that we explicitly need for the app to work.
Removed unnecessary use of
await
.1. What is the reason for the change?
useEffect is executing multiple times causing unnecessary reads from Async Storage.
2. What is the improvement/solution?
Force only one execution (onMount)
Screenshots/Recordings
Before: https://recordit.co/X1VFwVcQrh
After: https://recordit.co/R4OdM5QTM2
Issue
Progresses #5382
Checklist