Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.3] bugfix: for network asset education modal when network is added #4552

Merged
merged 4 commits into from
Jun 22, 2022
Merged

[5.3] bugfix: for network asset education modal when network is added #4552

merged 4 commits into from
Jun 22, 2022

Conversation

blackdevelopa
Copy link
Contributor

Description

This PR fixes #4551

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Screenshots/Recordings

If applicable, add screenshots or recordings to visualize the changes

Issue

Progresses #4551

@blackdevelopa blackdevelopa requested a review from a team as a code owner June 21, 2022 09:06
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@blackdevelopa blackdevelopa self-assigned this Jun 21, 2022
@blackdevelopa blackdevelopa added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jun 21, 2022
@blackdevelopa blackdevelopa changed the title bugfix for network asset education modal when network is added [5.3] bugfix: for network asset education modal when network is added Jun 21, 2022
gantunesr
gantunesr approved these changes Jun 22, 2022
View reviewed changes
Copy link
Member

@gantunesr gantunesr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

app/components/UI/DrawerView/index.js Outdated Show resolved Hide resolved
@gantunesr gantunesr added needs-qa Any New Features that needs a full manual QA prior to being added to a release. release-5.3.0 Issue or pull request that will be included in release 5.3.0 and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Jun 22, 2022
@cortisiko cortisiko added QA in Progress QA has started on the feature. QA Passed A successful QA run through has been done and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. QA in Progress QA has started on the feature. labels Jun 22, 2022
cortisiko
cortisiko approved these changes Jun 22, 2022
View reviewed changes
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮 🌮 🌮 🌮

@cortisiko cortisiko merged commit ef04558 into release/5.3.0 Jun 22, 2022
@cortisiko cortisiko deleted the bugfix-5.3 branch June 22, 2022 16:43
@github-actions github-actions bot locked and limited conversation to collaborators Jun 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gantunesr gantunesr gantunesr approved these changes

@cortisiko cortisiko cortisiko approved these changes

Assignees

@blackdevelopa blackdevelopa

Labels
QA Passed A successful QA run through has been done release-5.3.0 Issue or pull request that will be included in release 5.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blackdevelopa @cortisiko @gantunesr