Fix onramp error loop by providing payment method change #4528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alaahd
reviewed
Jun 17, 2022
| @@ -722,24 +722,27 @@ const AmountToBuy = () => { | |||
| <ScreenLayout> | |||
| <ScreenLayout.Body> | |||
| <ErrorView | |||
| icon="info" | |||
There was a problem hiding this comment.
non-blocking: I suggest we rename this prop to type instead of icon
There was a problem hiding this comment.
I avoid using type since it is a reserved word. Let's keep icon, as the other props also refer to elements of the view (icon, title, description, etc...)
alaahd
reviewed
Jun 17, 2022
locales/languages/en.json
Outdated
| @@ -1645,7 +1645,9 @@ | |||
| "no_providers_available": "No providers available", | |||
| "try_different_amount_to_buy_input": "Try choosing a different payment method or try to increase or reduce the amount you want to buy!", | |||
| "webview_received_error": "WebView received error status code: {{code}}", | |||
| "no_tokens_available": "There are currently no cryptocurrencies available to purchase on {{network}} in {{region}}", | |||
| "no_tokens_available_title": "No Tokens Available", | |||
| "no_tokens_available": "With the selected payment method, there are currently no tokens available to purchase on {{network}}", | |||
There was a problem hiding this comment.
I suggest to revise the message to "There are currently no tokens available to purchase on {{network}} with the selected payment method"
There was a problem hiding this comment.
@alaahd Fantastic concise edit. My only build is to add a period at the end like so: "There are currently no tokens available to purchase on {{network}} with the selected payment method."
mobularay
added
the
release-5.3.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes https://consensyssoftware.atlassian.net/browse/ONRAMP-90: A user remains in a loop after reaching a "no tokens available" error in the amount to buy.