Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3] Add On-Ramp Aggregator What's new modal #4484

Merged
merged 6 commits into from
Jun 13, 2022
+107 −31
Merged

[5.3] Add On-Ramp Aggregator What's new modal #4484

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
def2739
Add On-Ramp Aggregator What's new modal
wachunei Jun 9, 2022
2859f2b
Add images
wachunei Jun 9, 2022
2349ff5
Simplify image logic
Cal-L Jun 9, 2022
27b3fb7
Small adjustments
Cal-L Jun 9, 2022
330d8da
Change onlyUpdates to false
wachunei Jun 10, 2022
b63591f
Update comment
wachunei Jun 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/components/UI/WhatsNewModal/whatsNewList.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { WhatsNew } from './types';

export const whatsNew: WhatsNew = {
// All users that have <1.0.7 and are updating to >=1.0.7 should see
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's update this to either use the property names or what the actual versions are. In this case, both would be 5.3.0

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in b63591f

onlyUpdates: true, // Only users who updated the app will see this, not newly installs
onlyUpdates: false, // Only users who updated the app will see this, not newly installs
maxLastAppVersion: '5.3.0', // Only users who had a previous version < maxLaxtAppVersion version will see this
minAppVersion: '5.3.0', // Only users who updated to a version >= minAppVersion will see this
slides: [
Expand Down