Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.2.0][FIX] M6 - Fixes double tab opening when using metamask://dapp/ deep link schema #4383

Merged
merged 1 commit into from
May 23, 2022
Merged

[5.2.0][FIX] M6 - Fixes double tab opening when using metamask://dapp/ deep link schema #4383

merged 1 commit into from
May 23, 2022

Conversation

andreahaku
Copy link
Contributor

Description

When I tap a metamask://dapp/ deeplinks introduced in PR 4167 with MetaMask open in the background, then 2 tabs are opening

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Progresses #M6

@andreahaku andreahaku added needs-qa Any New Features that needs a full manual QA prior to being added to a release. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Code Impact - Low Minor code change that can safely applied to the codebase Priority - Medium Task with medium priority labels May 23, 2022
@andreahaku andreahaku requested a review from a team as a code owner May 23, 2022 10:11
@gantunesr gantunesr removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label May 23, 2022
@gantunesr gantunesr merged commit bd64bd0 into release/5.2.0 May 23, 2022
@gantunesr gantunesr deleted the fix/m6-metamask-dapp-schema-double-tab branch May 23, 2022 21:40
@github-actions github-actions bot locked and limited conversation to collaborators May 23, 2022
@plasmacorral
Copy link
Contributor

https://github.com/MetaMask/mobile-planning/issues/278#issuecomment-1136200593

@plasmacorral plasmacorral added QA'd - Issues Found QA has been complete, however issues have been discovered that need to be addressed and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels May 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gantunesr gantunesr gantunesr approved these changes

Assignees
No one assigned
Labels
Code Impact - Low Minor code change that can safely applied to the codebase Priority - Medium Task with medium priority QA'd - Issues Found QA has been complete, however issues have been discovered that need to be addressed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andreahaku @plasmacorral @gantunesr